Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 347 #402

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Issue 347 #402

merged 7 commits into from
Feb 11, 2025

Conversation

ericward-noaa
Copy link
Collaborator

PR to address this

#347

Copy link
Member

@seananderson seananderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the doc typo (offset->area)? Then run devtools::document(). Bump version number and add to NEWS.md. Then should be good to go. Thanks!

R/index.R Outdated
#' internally to match.
#' [predict.sdmTMB()] *or* a value of length 1 which will be repeated
#' internally to match *or* a character value representing the column
#' name of the offset.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct to 'name of area column'?

ericward-noaa and others added 2 commits February 11, 2025 13:52
update docs
add description to news
@seananderson seananderson merged commit ae77911 into main Feb 11, 2025
5 checks passed
@ericward-noaa ericward-noaa deleted the issue_347 branch February 11, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants