Skip to content

CAT-23430 - RDS instances of the cluster need tags #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
Use this URL for the source of the module. See the usage examples below for more details.

```hcl
github.com/pbs/terraform-aws-rds-module?ref=0.3.27
github.com/pbs/terraform-aws-rds-module?ref=x.y.z
```

### Alternative Installation Methods
Expand All @@ -28,7 +28,7 @@ Integrate this module like so:

```hcl
module "rds" {
source = "github.com/pbs/terraform-aws-rds-module?ref=0.3.27"
source = "github.com/pbs/terraform-aws-rds-module?ref=x.y.z"

# Required Parameters
private_hosted_zone = "example.local"
Expand All @@ -47,7 +47,7 @@ module "rds" {

If this repo is added as a subtree, then the version of the module should be close to the version shown here:

`0.3.27`
`x.y.z`

Note, however that subtrees can be altered as desired within repositories.

Expand Down
4 changes: 4 additions & 0 deletions instances.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ resource "aws_rds_cluster_instance" "writer" {
apply_immediately = var.apply_immediately
engine = var.engine
engine_version = local.engine_version

tags = local.tags
}

resource "aws_rds_cluster_instance" "reader" {
Expand All @@ -15,4 +17,6 @@ resource "aws_rds_cluster_instance" "reader" {
apply_immediately = var.apply_immediately
engine = var.engine
engine_version = local.engine_version

tags = local.tags
}