Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues that are breaking ruby 2.7 compatibility
external_encoding
option on CSV read and manually encodes back to the source encoding after CSV read. This took some experimentation, sinceCSV::read
has changed the encoding behavior.I made some changes to the Gemfile that seemed to be needed. I'm not sure if I agree with keeping the lock file out of version control, is this something worth discussing?
I also propose we add other versions of ruby to the CI, just in case.