Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with numpy2 #186

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

avalentino
Copy link
Contributor

This is a minimalistic patch to fix compatibility with numpy2.
It only partially supersedes #183, changes to teh CI configuration and setup.py/pyproject.toml are not included.

@djhoese
Copy link
Collaborator

djhoese commented Jan 28, 2025

Looks like CI changes might be needed. Is there any way you could apply your changes on top of that PR (especially if you can do it with the original commits)? Then I can try to get the CI working again.

@avalentino
Copy link
Contributor Author

Changes in affafa1 are not sufficient I fear.
I will try to fix ci.yaml by the way.

numpy2 doesn't support 3.8.
Not sure if something more needs to be
updated here..?
@avalentino avalentino force-pushed the bugfix/numpy2-compat branch from 4ecb78b to 7337f5f Compare January 28, 2025 20:51
@avalentino avalentino force-pushed the bugfix/numpy2-compat branch from 7337f5f to b92e4a9 Compare January 28, 2025 20:57
@avalentino avalentino force-pushed the bugfix/numpy2-compat branch from 0409525 to eab8137 Compare January 28, 2025 21:15
@djhoese
Copy link
Collaborator

djhoese commented Jan 29, 2025

I don't think my configuration is wrong, but the CI just can't seem to download conda packages consistently right now.

I think I've fixed the main problem with the system-provided libtiff which was a missing .py copy of the header. I generated it locally with docker and committed it. I've also updated the CI conda installation to not use defaults at all. Due to licensing issues no one should use the defaults conda channel unless they are paying money to Anaconda. We aren't, so we won't use it.

@djhoese
Copy link
Collaborator

djhoese commented Jan 29, 2025

My guess on the mac failures is:

#178

and the almost fix:

#179

@avalentino
Copy link
Contributor Author

Thanks @djhoese
For the record I think that also tiff_h_4_7_0.py is missing.
LibTIFF v4.7 seems to be the one used in the failed job on Mac.
Not sure if it makes any real difference.

@djhoese
Copy link
Collaborator

djhoese commented Jan 29, 2025

Added it but mac still failing. I really don't understand what is going on with conda downloads in CI today. A ton of them fail and restarting sometimes fixes it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13040366041

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 54.638%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libtiff/libtiff_ctypes.py 6 8 75.0%
libtiff/test_bittools.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
libtiff/libtiff_ctypes.py 1 75.22%
Totals Coverage Status
Change from base Build 8510299790: -0.03%
Covered Lines: 2350
Relevant Lines: 4301

💛 - Coveralls

@djhoese
Copy link
Collaborator

djhoese commented Jan 29, 2025

Ok so everything passes except mac.

@djhoese djhoese added the bug label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants