-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with numpy2 #186
base: master
Are you sure you want to change the base?
Conversation
Looks like CI changes might be needed. Is there any way you could apply your changes on top of that PR (especially if you can do it with the original commits)? Then I can try to get the CI working again. |
Changes in affafa1 are not sufficient I fear. |
numpy2 doesn't support 3.8. Not sure if something more needs to be updated here..?
4ecb78b
to
7337f5f
Compare
7337f5f
to
b92e4a9
Compare
0409525
to
eab8137
Compare
oldest-supported-numpy is deprecated
I don't think my configuration is wrong, but the CI just can't seem to download conda packages consistently right now. I think I've fixed the main problem with the system-provided libtiff which was a missing |
Thanks @djhoese |
Added it but mac still failing. I really don't understand what is going on with conda downloads in CI today. A ton of them fail and restarting sometimes fixes it. |
Pull Request Test Coverage Report for Build 13040366041Details
💛 - Coveralls |
Ok so everything passes except mac. |
This is a minimalistic patch to fix compatibility with numpy2.
It only partially supersedes #183, changes to teh CI configuration and
setup.py
/pyproject.toml
are not included.