Skip to content

Conversation

david-sharer
Copy link

When building for the first time under windows, I was met with this:
image

The normalization convention of the project was ignored for .mjs files.
The culprit appears to be this .gitattributes file -- which only has .js and .ts
I have added CJS + MJS extensions and the TypeScript variants.

Perhaps the contents from your template would be better, tho it doesn't include TS variants.
https://github.com/cto-af/create/blob/main/.gitattributes

Note

Additionally, I had to follow instructions here before the normalization "took".

# Note: these didn't work
git add --renormalize .  # Update index with renormalized files
git status               # Show the files that will be normalized
git commit -m "Introduce end-of-line normalization"

# Note: These also did not work
git read-tree --empty   # Clean index, force re-scan of working directory
git add .
git status        # Show files that will be normalized
git commit -m "Introduce end-of-line normalization"

# Toward the bottom of the answer, I had to "refresh the working tree"
git rm --cached -r .
git reset --hard

@hildjj
Copy link
Contributor

hildjj commented Jul 14, 2025

Please add yourself to AUTHORS if you aren't already.
Please add a CHANGELOG entry.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (ee21e45) to head (7741401).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #639   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files          34       34           
  Lines        4283     4283           
=======================================
  Hits         4261     4261           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hildjj hildjj merged commit da94bc8 into peggyjs:main Jul 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants