-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input_amount to events #451
base: staging
Are you sure you want to change the base?
Add input_amount to events #451
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ount for amount_type event
@@ -0,0 +1,37 @@ | |||
import { create } from 'zustand'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pendulum-chain/devs let me know if you like the addition of this state, if you prefer it to be more minimal (only fromAmount
) or to avoid this altogether.
Although it adds extra code, I found it less confusing than passing fromAmount
to the event context.
Addresses #371 and #412
Changes
input_amount
towallet_connect
,amount_type
andform_error
events.amount_type
we need to delay a few seconds to avoid the amount to just be0
or the default. If the interaction with the form is with the tokens, then the initial default amount will be sent.wallet_connect
a new minimal storage is added, to avoid passing props to the context.network_selected
.Tag manager
Adds a new variable
{{DLV | input_amount}}
and link it towallet_connect
,amount_type
andform_error
.Adds a new variable
{{DLV | network_selected}}
, and link it towallet_connect
.Tested on the preview of tag manager and all events now register this new parameter.