Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IN-PROGRESS] Improve error priority. #459

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

[IN-PROGRESS] Improve error priority. #459

wants to merge 1 commit into from

Conversation

gianfra-t
Copy link
Contributor

@gianfra-t gianfra-t commented Feb 6, 2025 •
edited
Loading

#413

NOTE: minimum balance error is commented out for preview purposes.

Changes

  • Show always an error about the maximum offramp for the given FIAT, instead of a liquidity error, for the case both are present.
  • Rephrase the liquidity error.
  • Use a cache with exchange rates, so that we can calculate the maximum offramp limit even with the quote displays an error.

@gianfra-t gianfra-t linked an issue Feb 6, 2025 that may be closed by this pull request
Update the error message priority #413
Open
@netlify Netlify
Copy link

netlify bot commented Feb 6, 2025 •
edited
Loading

✅ Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit c1ff8c9
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/67a4fd81b6010f000803b96e
😎 Deploy Preview https://deploy-preview-459--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the error message priority
1 participant
@gianfra-t