Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provides = time-daemon to deb metadata #1817

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcpherrinm
Copy link

@mcpherrinm mcpherrinm commented Feb 6, 2025

In Debian and Ubuntu, time-daemon is provided/conflict/replace by all of chrony, ntpsec, openntpd, systemd-timesyncd

This helps to ensure there's not multiple fighting NTP implementations, and allows other packages to depend on having NTP generically.

Having ntpd-rs provide it eases switching them out and keeping dependencies satisfied.

In Debian and Ubuntu, it is provided by all of chrony, ntpsec, openntpd, systemd-timesyncd

Having ntpd-rs provide it eases switching them out and keeping dependencies satisfied.
@mcpherrinm
Copy link
Author

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.41%. Comparing base (a46f34b) to head (a5e583f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1817   +/-   ##
=======================================
  Coverage   81.40%   81.41%           
=======================================
  Files          68       68           
  Lines       21610    21610           
=======================================
+ Hits        17592    17594    +2     
+ Misses       4018     4016    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

to match the other packages upstream
@mcpherrinm
Copy link
Author

Manual testing on a Debian Bookworm host shows it correct swaps out chrony:

ntpd-rs$ sudo apt install /home/mattm/code/ntpd-rs/target/debian/ntpd-rs_1.4.0-1_amd64.deb
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'ntpd-rs' instead of '/home/mattm/code/ntpd-rs/target/debian/ntpd-rs_1.4.0-1_amd64.deb'
The following packages will be REMOVED:
  chrony
The following packages will be upgraded:
  ntpd-rs
1 upgraded, 0 newly installed, 1 to remove and 61 not upgraded.
Need to get 0 B/17.9 MB of archives.
After this operation, 653 kB disk space will be freed.
Do you want to continue? [Y/n] Y
Get:1 /home/mattm/code/ntpd-rs/target/debian/ntpd-rs_1.4.0-1_amd64.deb ntpd-rs amd64 1.4.0-1 [17.9 MB]
Reading changelogs... Done
(Reading database ... 68819 files and directories currently installed.)
Removing chrony (4.3-2+deb12u1) ...
(Reading database ... 68787 files and directories currently installed.)
Preparing to unpack .../ntpd-rs_1.4.0-1_amd64.deb ...
Unpacking ntpd-rs (1.4.0-1) over (1.4.0-1) ...
Setting up ntpd-rs (1.4.0-1) ...
ntpd-rs-metrics.service is a disabled or a static unit not running, not starting it.
Processing triggers for man-db (2.11.2-2) ...

@davidv1992 davidv1992 requested a review from rnijveld February 7, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants