Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SEO support #7

Merged
merged 3 commits into from
Jul 24, 2024
Merged

feat: add SEO support #7

merged 3 commits into from
Jul 24, 2024

Conversation

VanishMax
Copy link
Contributor

@VanishMax VanishMax commented Jul 24, 2024

  • Added better SEO support
  • Added images for favicon and logo
  • Removed the empty footer, added Discord link, fixed the link to GitHub tree
  • Ensured consistency across the pages to have H1 tag
  • Created empty pages, so the links don't point to nothing

@VanishMax VanishMax requested a review from hdevalence July 24, 2024 11:20
@VanishMax VanishMax self-assigned this Jul 24, 2024
Copy link

github-actions bot commented Jul 24, 2024

Visit the preview URL for this PR (updated for commit ad107e3):

https://penumbra-guide--pr7-feat-seo-xs3p9ro4.web.app

(expires Wed, 31 Jul 2024 14:22:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c64218fe717b75c9724a23946df883a1adf10faa

Comment on lines +1 to +2
# Development

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was cutting these out and replacing them with a title: attribute since the title is already displayed at the top of the article and it looked weird to duplicate (even if the top display is in smaller text)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on weirdness. The top title is actually a breadcrumbs link. It can't be used as a title since it is small in size and, if the page is nested, it renders as "page1 -> page2".

I found a way to remove the breadcrumbs from the first-level pages (e.g. /dex but not /web/prax), and it looks better now:

image

And here are nested pages:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK Cool, good fix

@VanishMax VanishMax requested a review from hdevalence July 24, 2024 14:22
@hdevalence hdevalence merged commit 9f0ec1a into main Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants