Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update bundled minifront #5089

Closed
conorsch opened this issue Feb 14, 2025 · 1 comment
Closed

build: update bundled minifront #5089

conorsch opened this issue Feb 14, 2025 · 1 comment
Assignees
@conorsch

Comments

@conorsch
Copy link
Contributor

Describe the bug
The bundled minifront that ships with pd is out of date. Building locally from main branch, and navigating to http://localhost:8080/app/, I see:

Version [ba65187](http://localhost:8080/app/[email protected]:penumbra-zone/web/commits/ba65187648cbc963c41ea4297e91676720026acd) - Aug 27 2024 09:24:09 GMT-07

which is quite old!

Screenshots

Image

Additional context
As recently as #4965 we tried to update those bundles, but for some reason that change didn't take. Let's figure out why it failed and get another update out.
@conorsch conorsch self-assigned this Feb 14, 2025
@conorsch conorsch mentioned this issue Feb 14, 2025
Merged
2 tasks
conorsch added a commit to penumbra-zone/web that referenced this issue Feb 14, 2025
@conorsch
lint: shellcheck on minifront bundled asset script
fb8da24 
I ran `shellcheck` on the script used to export a bundled minifront,
suitable for inclusion in `pd`. These are small changes intended to make
the script more resilient, e.g. failing fast and handling directories
with spaces in the name.

Prepared while working on
penumbra-zone/penumbra#5089.
This was referenced Feb 14, 2025
Merged
Open
Closed
conorsch added a commit to penumbra-zone/web that referenced this issue Feb 14, 2025
@conorsch
lint: shellcheck on minifront bundled asset script (#2056)
b97fb7c 
I ran `shellcheck` on the script used to export a bundled minifront,
suitable for inclusion in `pd`. These are small changes intended to make
the script more resilient, e.g. failing fast and handling directories
with spaces in the name.

Prepared while working on
penumbra-zone/penumbra#5089.
@conorsch
Copy link
Contributor Author

Resolved via #5090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorsch conorsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@conorsch