You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran shellcheck on the script used to export a bundled minifront, suitable for inclusion in pd. These are small changes intended to make the script more resilient, e.g. failing fast and handling directories with spaces in the name.
I have ensured that any relevant minifront changes do not cause the existing extension to break.
No app-code changes, only a script to export artifacts is changed. Still, I did consume the results of this modified script, as part of testing for penumbra-zone/penumbra#5089.
I ran `shellcheck` on the script used to export a bundled minifront,
suitable for inclusion in `pd`. These are small changes intended to make
the script more resilient, e.g. failing fast and handling directories
with spaces in the name.
Prepared while working on
penumbra-zone/penumbra#5089.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I suspect there's more this script could do in clearing out stale local build caches, such as the dist/ dirs, to ensure the latest artifacts are built cleanly, and nothing's reused. Will keep a close eye on that behavior, and aim to update the bundle more frequently. IMO this PR can be merged as-is as a nominal improvement.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
I ran
shellcheckon the script used to export a bundled minifront, suitable for inclusion inpd. These are small changes intended to make the script more resilient, e.g. failing fast and handling directories with spaces in the name.Prepared while working on
penumbra-zone/penumbra#5089.
Related Issue
Refs penumbra-zone/penumbra#5089.
Checklist Before Requesting Review
No app-code changes, only a script to export artifacts is changed. Still, I did consume the results of this modified script, as part of testing for penumbra-zone/penumbra#5089.