Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex: track outflows in position manager #5030

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Jan 30, 2025

Describe your changes

Close #5028.

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Consensus and state breaking

@erwanor erwanor added consensus-breaking breaking change to execution of on-chain data A-dex Area: Relates to the dex state-breaking breaking change to on-chain data labels Jan 30, 2025
Copy link
Contributor

@cronokirby cronokirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, since position manager should be the only place updating positions.

@erwanor erwanor merged commit eff0c94 into protocol/lqt_branch Jan 30, 2025
13 checks passed
@erwanor erwanor deleted the erwan/dex_track_outflows branch January 30, 2025 17:51
conorsch pushed a commit that referenced this pull request Jan 31, 2025
## Describe your changes

Close #5028.

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Consensus and state breaking
conorsch pushed a commit that referenced this pull request Feb 4, 2025
## Describe your changes

Close #5028.

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Consensus and state breaking
conorsch pushed a commit that referenced this pull request Feb 5, 2025
## Describe your changes

Close #5028.

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Consensus and state breaking
conorsch pushed a commit that referenced this pull request Feb 5, 2025
## Describe your changes

Close #5028.

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Consensus and state breaking
conorsch pushed a commit that referenced this pull request Feb 14, 2025
## Describe your changes

Close #5028.

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Consensus and state breaking
conorsch pushed a commit that referenced this pull request Feb 21, 2025
## Describe your changes

Close #5028.

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Consensus and state breaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dex Area: Relates to the dex consensus-breaking breaking change to execution of on-chain data state-breaking breaking change to on-chain data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants