Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pindexer: add dex block summary #5063
pindexer: add dex block summary #5063
Changes from all commits
8eca959
93ac969
bb5e939
f63499c
62b19c4
bea4ceb
e0bc3ff
f5bbf9d
6468ef2
5ded81f
a5ed522
deb055b
ce6f058
9ac0e31
b0193d4
a6af04d
071d53f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cronokirby noticed that some inserts fail if we are adding a
UNIQUE
constraint on height, but my understanding is that this part of the pipeline should have exactly once semantics on delivery. is that right?wondering if this is caused by the catchup logic: https://github.com/penumbra-zone/penumbra/blob/erwan/pindexer_block_summary/crates/util/cometindex/src/indexer/indexing_state.rs#L271 (
<=
vs.<
). unsure.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a first glance this line seems wrong, yeah ; I think we should optimistically merge this and then look at re-adding in a unique constraint and making sure indexing logic doesn't repeat events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DevOps hiring for RC
https://web3.career/staff-sre-engineer-platform-phantom/95791
Questions:
Given a greenfield project that needs hosting, how do you approach the problem? What do you focus on first? What information do you require? (Look for keywords like monitoring, network surface, observability, SLAs; explore from there.)
Sometimes on small teams there can be disagreements about architecture. Can you tell me about a time when you disagreed with a technical decision made by a colleague, and how you approached that situation?
Describe your preferred working style. Do you prefer to communicate via group chat in Slack or similar, via DMs, on Github issues, on video calls?
What types of work, whether backend systems administration or otherwise, do you find draining? What about rewarding?
If we were to move forward with this role,how could Radiant Commons support you? What does supportive work environment look like to you?
How do you prefer to run software if left to your own devices? Do you like container orchestration?
How do you decide whether a service should be self-run, internally to the company, versus paid for as a Saas?
Can you share an "war stories" about running production infrastructure, incident response?
When it comes to writing code vs automating infrastructure, which do you prefer? HOw are those responsibilities different, how related?
conor in 🌐 Antigonus in ~/src/penumbra on 🌱 main [$] via 🦀 v1.83.0 via ❄ impure (nix-shell-env)
❯ 1
After deploying
pindexer
atv1.0.2
, the mainnet events pipeline stalled out:After switching to a build based on #5095, that error becomes:
which looks like a genuine problem. I'm surprised that the
CREATE TYPE batch_swap_summary AS
declaration in the modified schema isn't sufficient.