Validate zod only in dev (#802)

packages/types/src/validation.test.ts

@@ -1,18 +1,9 @@
-import { afterEach, beforeEach, describe, expect, it, Mock, vi } from 'vitest';
+import { afterEach, describe, expect, it, vi } from 'vitest';
 import { z } from 'zod';
 import { isType, validateSchema } from './validation';
 
 describe('validation', () => {
   describe('validateSchema()', () => {
-    let mockLogger: Mock;
-
-    beforeEach(() => {
-      mockLogger = vi.fn();
-      vi.stubGlobal('console', {
-        error: mockLogger,
-      });
-    });
-
     afterEach(() => {
       vi.unstubAllEnvs();
       vi.unstubAllGlobals();
@@ -49,7 +40,6 @@ describe('validation', () => {
       expect(() => {
         validateSchema(z.string(), 123);
       }).not.toThrow();
-      expect(mockLogger).toHaveBeenCalledOnce();
     });
 
     it('Does not throw in chrome ext prod', () => {
@@ -69,7 +59,6 @@ describe('validation', () => {
       expect(() => {
         validateSchema(z.string(), 123);
       }).not.toThrow();
-      expect(mockLogger).toHaveBeenCalledOnce();
     });
 
     it('Does not throw in browser env', () => {
@@ -82,7 +71,6 @@ describe('validation', () => {
       expect(() => {
         validateSchema(z.string(), 123);
       }).not.toThrow();
-      expect(mockLogger).toHaveBeenCalledOnce();
     });
 
     it('Does not throw in unknown env', () => {
@@ -95,7 +83,6 @@ describe('validation', () => {
       expect(() => {
         validateSchema(z.string(), 123);
       }).not.toThrow();
-      expect(mockLogger).toHaveBeenCalledOnce();
     });
   });
 

packages/types/src/validation.ts

@@ -1,21 +1,13 @@
 import { z, ZodTypeAny } from 'zod';
 import { isDevEnv } from './environment';
 
-// In production, we do not want to throw validation errors, but log them.
-// Given the extension update cycle, we want to opt for grace degradation.
-// In our CI/CD, we'll throw validation errors so they can be fixed at build time.
+// Given performance critical nature of some features (like syncing),
+// we only validate in dev mode in attempts to catch any schema variance
 export const validateSchema = <T>(schema: z.ZodSchema<T>, data: unknown): T => {
-  const result = schema.safeParse(data);
-
-  if (result.success) {
-    return result.data;
+  if (isDevEnv()) {
+    return schema.parse(data);
   } else {
-    if (isDevEnv()) {
-      throw result.error;
-    } else {
-      console.error(result.error);
-      return data as T;
-    }
+    return data as T;
   }
 };