correctly serialize headers and timeout #2071
Merged
+60
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ceca6f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
turbocrime
force-pushed
the
transport-dom-headers
branch
2 times, most recently
from
5dcd3e5 to
9d32ff2
Compare
TalDerei
approved these changes
Feb 22, 2025
There was a problem hiding this comment.
this looks good, but seems to conflict with #2034 (comment) that was moved to #2058? approving optimistically, and should we narrow the scope of that PR to only disable client streaming?
|
yes, breaking up PR #2058, it was kind of a random collection |
turbocrime
force-pushed
the
transport-dom-headers
branch
9 times, most recently
from
7cba666 to
50e0c6b
Compare
turbocrime
force-pushed
the
transport-dom-headers
branch
from
50e0c6b to
38a38ff
Compare
turbocrime
force-pushed
the
transport-dom-headers
branch
from
38a38ff to
ece8b54
Compare
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Restrict the use of
HeadersInitin aTransportEventorTransportErrorto only permit jsonifiable members.Serialize timeout into the request header as in typical connectrpc.
Technically, an exported type becomes narrower, but the now-omitted member was invalid, and no external API has changed its accepted input/output formats.
Related Issue
@penumbra-zone/transport-domtypeTransportEventpermits a non-transferable field #2070@penumbra-zone/transport-domtransport accepts timeout configuration but only uses it locally #2072Checklist Before Requesting Review