Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12888 Implemented new Patroni dashboard. #1566

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

guriandoro
Copy link
Contributor

@guriandoro guriandoro commented Feb 15, 2024

New dashboard as showcased in https://www.percona.com/blog/monitoring-a-postgresql-patroni-cluster/.

There are some minor differences with the one shown in the blog, like separating Patroni and Postrges configurations/panels. I think it's cleaner in this way. The WAL location graphs have hidden rate queries, which can be helpful in some cases, but also add a bit of noise. I was not sure what to do with them, so I decided to leave them disabled by default.

Let me know what you think about it.

Thanks!

FB: Percona-Lab/pmm-submodules#3546

https://perconadev.atlassian.net/browse/PMM-12888

"name": "replication_set",
"options": [],
"query": {
"query": "label_values({__name__=~\"pg_up|mysql_up|mongodb_up|proxysql_mysql_status_active_transactions\"}, replication_set)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if querying for anything other than pg_up is of relevance here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question. I was not using this, and just opted for:

Environment / Cluster / Service Name / Scope Name

However, the pmm-admin add external command offers the --replication-set argument, so we could add it. The postgresql exporter also has this argument available, so this will boil down to how we want to do it for Postgres in general.

Let me know and I can do the changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it as is for Experimental.
If this is what I'm thinking - it's the "how to get the list of Replicas in general," and for now, we use the metrics, but when our inventory becomes more reliable ("labels auto discovery") - we must move it to be based on inventory, probably.

@rnovikovP rnovikovP merged commit 5924f74 into percona:main Mar 4, 2024
6 of 7 checks passed
YashSartanpara1 pushed a commit that referenced this pull request Mar 4, 2024
* PMM-12888 Implemented new Patroni dashboard.

* Change dashboard UID to NULL.

Co-authored-by: Alex Demidoff <[email protected]>

---------

Co-authored-by: Roman Novikov <[email protected]>
Co-authored-by: Alex Demidoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants