PMM-12971 Update default max connection logic

percona · May 21, 2024 · 912d148 · 912d148
1 parent 49b9dd3
commit 912d148
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 25 deletions.
diff --git a/...d-instance/components/AddRemoteInstance/FormParts/AdditionalOptions/AdditionalOptions.tsx b/...d-instance/components/AddRemoteInstance/FormParts/AdditionalOptions/AdditionalOptions.tsx
@@ -58,7 +58,8 @@ export const PostgreSQLAdditionalOptions: FC<PostgreSQLAdditionalOptionsProps> =
   const getAutoDiscoveryLimitValue = (type: AutoDiscoveryOptionsInterface) =>
     type === AutoDiscoveryOptionsInterface.disabled ? -1 : 10;
 
-  const getMaxConnectionLimitValue = (type: MaxConnectionLimitOptionsInterface) => 5;
+  const getMaxConnectionLimitValue = (type: MaxConnectionLimitOptionsInterface) =>
+    type === MaxConnectionLimitOptionsInterface.disabled ? null : 5;
 
   useEffect(() => {
     setSelectedValue(selectedOption);
@@ -120,8 +121,8 @@ export const PostgreSQLAdditionalOptions: FC<PostgreSQLAdditionalOptionsProps> =
               key="maxExporterConnections"
               name="maxExporterConnections"
               defaultValue={5}
+              placeholder={'5'}
               disabled={maxConnSelectedValue !== MaxConnectionLimitOptionsInterface.enabled}
-              validators={validators}
               label={Messages.form.labels.postgresqlDetails.maxConnectionLimit}
               tooltipText={Messages.form.tooltips.postgresqlDetails.maxConnectionLimit}
             />

diff --git a/...tance/components/AddRemoteInstance/FormParts/AdditionalOptions/AdditionalOptions.types.ts b/...tance/components/AddRemoteInstance/FormParts/AdditionalOptions/AdditionalOptions.types.ts
@@ -13,5 +13,4 @@ export enum AutoDiscoveryOptionsInterface {
 export enum MaxConnectionLimitOptionsInterface {
   enabled = 'enabled',
   disabled = 'disabled',
-  custom = 'custom',
 }
diff --git a/...RemoteInstance/FormParts/PostgreSQLConnectionDetails/PostgreSQLConnectionDetails.test.tsx b/...RemoteInstance/FormParts/PostgreSQLConnectionDetails/PostgreSQLConnectionDetails.test.tsx
@@ -22,26 +22,4 @@ describe('PostgreSQL connection details:: ', () => {
 
     expect(screen.getByTestId('maxQueryLength-text-input')).toHaveValue('1000');
   });
-
-  it('should have max connection field for pg and rds pg', () => {
-    render(
-      <Form
-        onSubmit={jest.fn()}
-        render={() => <PostgreSQLConnectionDetails remoteInstanceCredentials={{ isAzure: false }} />}
-      />
-    );
-    const connectionlimitInput = screen.queryByTestId('maxExporterConnections-text-input');
-    expect(connectionlimitInput).toBeInTheDocument();
-  });
-
-  it('should not have max connection field for Azure', () => {
-    render(
-      <Form
-        onSubmit={jest.fn()}
-        render={() => <PostgreSQLConnectionDetails remoteInstanceCredentials={{ isAzure: true }} />}
-      />
-    );
-    const connectionlimitInput = screen.queryByTestId('maxExporterConnections-text-input');
-    expect(connectionlimitInput).not.toBeInTheDocument();
-  });
 });