Handle Error from nonSystemCollectionsCount in exporter.go#590
Closed
rriverak wants to merge 3 commits intopercona:mainfrom
Closed
Handle Error from nonSystemCollectionsCount in exporter.go#590rriverak wants to merge 3 commits intopercona:mainfrom
rriverak wants to merge 3 commits intopercona:mainfrom
Conversation
rriverak
requested review from
a team,
floatinginbits and
tshcherban
and removed request for
a team
|
|
tshcherban
approved these changes
Dec 23, 2022
ghost
mentioned this pull request
4 tasks
Contributor
|
Hello, it seems like this change won't end loop since there is a check for e.getTotalCollectionsCount() <= 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #562 , we have very common access violations which seem unnecessary.
Handling the error from
nonSystemCollectionsCountshould end the access error loop here...Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum or Discord.