PBM-1504 Add support for Workload Identity Authentication #1021
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,7 @@ import ( | |
| "github.com/aws/aws-sdk-go/service/s3" | ||
| "github.com/aws/aws-sdk-go/service/s3/s3manager" | ||
| "github.com/aws/aws-sdk-go/service/sts" | ||
| "golang.org/x/oauth2/google" | ||
|
|
||
| "github.com/percona/percona-backup-mongodb/pbm/errors" | ||
| "github.com/percona/percona-backup-mongodb/pbm/log" | ||
|
|
@@ -43,6 +44,7 @@ type Config struct { | |
| Provider string `bson:"provider,omitempty" json:"provider,omitempty" yaml:"provider,omitempty"` | ||
| Region string `bson:"region" json:"region" yaml:"region"` | ||
| EndpointURL string `bson:"endpointUrl,omitempty" json:"endpointUrl" yaml:"endpointUrl,omitempty"` | ||
| ServiceAccount string `bson:"serviceAccount,omitempty" json:"serviceAccount" yaml:"serviceAccount,omitempty"` | ||
| ForcePathStyle *bool `bson:"forcePathStyle,omitempty" json:"forcePathStyle,omitempty" yaml:"forcePathStyle,omitempty"` | ||
| Bucket string `bson:"bucket" json:"bucket" yaml:"bucket"` | ||
| Prefix string `bson:"prefix,omitempty" json:"prefix,omitempty" yaml:"prefix,omitempty"` | ||
|
|
@@ -159,6 +161,9 @@ func (cfg *Config) Equal(other *Config) bool { | |
| if cfg.EndpointURL != other.EndpointURL { | ||
| return false | ||
| } | ||
| if cfg.ServiceAccount != other.ServiceAccount { | ||
| return false | ||
| } | ||
| if cfg.Bucket != other.Bucket { | ||
| return false | ||
| } | ||
|
|
@@ -196,6 +201,9 @@ func (cfg *Config) Cast() error { | |
| if cfg.Region == "" { | ||
| cfg.Region = defaultS3Region | ||
| } | ||
| if cfg.ServiceAccount == "" { | ||
| cfg.ServiceAccount = "default" | ||
| } | ||
| if cfg.ForcePathStyle == nil { | ||
| cfg.ForcePathStyle = aws.Bool(true) | ||
| } | ||
|
|
@@ -550,6 +558,20 @@ func (s *S3) session() (*session.Session, error) { | |
| }}) | ||
| } | ||
|
|
||
| // If using GCE, attempt to retrieve access token from metadata server | ||
| if onGCE() { | ||
| tokenSource := google.ComputeTokenSource(s.opts.ServiceAccount, "") | ||
| token, err := tokenSource.Token() | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "get GCP token") | ||
| } | ||
| providers = append(providers, &credentials.StaticProvider{Value: credentials.Value{ | ||
| AccessKeyID: "GCP_OAUTH_TOKEN", | ||
| SecretAccessKey: "GCP_OATH_TOKEN", | ||
| SessionToken: token.AccessToken, | ||
| }}) | ||
| } | ||
|
|
||
| awsSession, err := session.NewSession() | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "new session") | ||
|
|
@@ -617,3 +639,24 @@ func awsLogger(l log.LogEvent) aws.Logger { | |
| l.Debug(msg, xs...) | ||
| }) | ||
| } | ||
|
|
||
| func onGCE() bool { | ||
| client := http.Client{ | ||
| Timeout: 100 * time.Millisecond, | ||
| } | ||
|
|
||
| req, err := http.NewRequest("GET", "http://169.254.169.254/computeMetadata/v1/", nil) | ||
|
There was a problem hiding this comment. shouldn't "http://metadata.google.internal" be used instead of the hardcoded IP? |
||
| if err != nil { | ||
| return false | ||
| } | ||
|
|
||
| req.Header.Add("Metadata-Flavor", "Google") | ||
|
|
||
| resp, err := client.Do(req) | ||
| if err != nil { | ||
| return false | ||
| } | ||
| defer resp.Body.Close() | ||
|
|
||
| return resp.StatusCode == http.StatusOK | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
GCP_OATH_TOKENa typo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, no not a typo, the fields are mandatory but they're just set to placeholder values here since they're not used for GCS.