PBM-1506 GCS support concurrent downloading #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into PBM-1506-GCS-support-concurrent-downloading
boris-ilijic
approved these changes
Mar 20, 2025
| obj := bucketHandle.Object(path.Join(g.opts.Prefix, fname)) | ||
| reader, err := obj.NewRangeReader(ctx, start, length) | ||
| if err != nil { | ||
| if errors.Is(err, gcs.ErrObjectNotExist) || (err != nil && isRangeNotSatisfiable(err)) { |
There was a problem hiding this comment.
Suggested change
| if errors.Is(err, gcs.ErrObjectNotExist) || (err != nil && isRangeNotSatisfiable(err)) { | |
| if errors.Is(err, gcs.ErrObjectNotExist) || isRangeNotSatisfiable(err) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for https://perconadev.atlassian.net/browse/PBM-1506
It reintroduces the ability to download a single large file in parallel for Google Cloud Storage (GCS) after introducing Google's native SDK.
Users can speed up restores by using multiple workers to download big files in parallel. With these changes, it will be available for S3 and GCS but has been made with consideration of supporting additional storage types in the future.
The changes reuse the existing logic from the S3 download module.