PBM-1482: Selective Restore hangs on oplog replay and doesn't finish #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For bigger files, config.chunks are just partially applied during the selective restore. This fix applies to the whole config.chunks collection's docs from the backup file.
veceraj
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for https://perconadev.atlassian.net/browse/PBM-1482
PR fixes two issues:
configdb related collections, backup files were not closed, which implies possible resource leaks and deadlock in case when S3 compatible storage is used (while usingio.Pipe).config.chunksdatabase, not all documents were processed, only the first batch of documents was processed.