PBM-1547 Spike PoC for control collection rs #1167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +66,7 @@ func runConfig( | |||
| var o confVals | |||
| rsnc := false | |||
| for k, v := range c.set { | |||
| err := config.SetConfigVar(ctx, conn, k, v) | |||
| err := config.SetConfigVar(ctx, ccrsConn, k, v) | |||
There was a problem hiding this comment.
There is silent but critical bug up in the stack, when PBM fetches cluster time of CCRS, instead of target cluster:
percona-backup-mongodb/pbm/config/config.go
Line 617 in 1e9489c
| m *restore.RestoreMeta, | ||
| node string, | ||
| status defs.Status, | ||
| tskew int64, | ||
| ) error { | ||
| ep, _ := config.GetEpoch(ctx, conn) | ||
| ep, _ := config.GetEpoch(ctx, ccrsConn) | ||
| l := log.FromContext(ctx). | ||
| NewEvent(string(ctrl.CmdRestore), m.Backup, m.OPID, ep.TS()) | ||
| stg, err := util.GetStorage(ctx, conn, node, l) |
There was a problem hiding this comment.
It should be CCRS connection
| m *restore.RestoreMeta, | ||
| node string, | ||
| status defs.Status, | ||
| tskew int64, | ||
| ) error { | ||
| ep, _ := config.GetEpoch(ctx, conn) | ||
| ep, _ := config.GetEpoch(ctx, ccrsConn) | ||
| l := log.FromContext(ctx). | ||
| NewEvent(string(ctrl.CmdRestore), m.Backup, m.OPID, ep.TS()) | ||
| stg, err := util.GetStorage(ctx, conn, node, l) |
There was a problem hiding this comment.
Also this one should use ccrs connection:
percona-backup-mongodb/cmd/pbm/restore.go
Line 271 in 1e9489c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves as a prototype for porting the control collection to a separate mongo instance. A new
ccrsUriparameter for pbm-agent and pbm has been added and as result Control collection data is stored only in CCRS. This parameter is optional and if omitted pbm reuses lead conn.In some functions additional parameter for ccrsConn has been added when both conns were needed.
The remaining part of Spike will be presented in slides: [url to slides] - wip