CLOUD-727 update go ver and go modules #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hors
commented
Jan 30, 2025
•
hors
commented
gkech
reviewed
Jan 30, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.22 AS go_builder | |||
| FROM golang:1.23 AS go_builder | |||
There was a problem hiding this comment.
we can useFROM golang:1.23.5 given that we are building pgbackrest using go 1.23.5 in go.mod
There was a problem hiding this comment.
@gkech yes we can but by using 1.23 we will have always the latest version
Is it critical to use 1.23.5?
egegunes
approved these changes
Jan 30, 2025
gkech
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.