-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPG-699: Add pgvector support #991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, I have just one comment.
@@ -186,6 +186,7 @@ type ExtensionsSpec struct { | |||
PGStatMonitor bool `json:"pgStatMonitor,omitempty"` | |||
PGAudit bool `json:"pgAudit,omitempty"` | |||
PGStatStatements bool `json:"pgStatStatements,omitempty"` | |||
PGVector bool `json:"pgvector,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use camelCase for pgvector as we have for other extensions, like pgVector
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the official style: https://github.com/pgvector/pgvector
commit: 4e1f4e4 |
CHANGE DESCRIPTION
Accompanying PR: percona/percona-docker#1098
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability