Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-699: Add pgvector support #991

Merged
merged 4 commits into from
Jan 2, 2025
Merged

K8SPG-699: Add pgvector support #991

merged 4 commits into from
Jan 2, 2025

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented Dec 23, 2024

K8SPG-699 Powered by Pull Request Badge

CHANGE DESCRIPTION

Accompanying PR: percona/percona-docker#1098

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@egegunes egegunes added this to the v2.6.0 milestone Dec 23, 2024
Copy link
Contributor

@inelpandzic inelpandzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, I have just one comment.

@@ -186,6 +186,7 @@ type ExtensionsSpec struct {
PGStatMonitor bool `json:"pgStatMonitor,omitempty"`
PGAudit bool `json:"pgAudit,omitempty"`
PGStatStatements bool `json:"pgStatStatements,omitempty"`
PGVector bool `json:"pgvector,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use camelCase for pgvector as we have for other extensions, like pgVector?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the official style: https://github.com/pgvector/pgvector

@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 19 out of 19

commit: 4e1f4e4
image: perconalab/percona-postgresql-operator:PR-991-4e1f4e43a

@hors hors merged commit 463bf42 into main Jan 2, 2025
17 checks passed
@hors hors deleted the K8SPG-699 branch January 2, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants