K8SPSMDB-1304 Adding Recommended Labels

[cshiv]

CHANGE DESCRIPTION

Problem:
Short explanation of the problem.
Labels could be improved by using standard and recommended labels.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.
Adding recommended labels give good visibility.

Changes below doesn't have any functional impact. I am not sure if I need to add any test cases. Kindly advise. I have kept checklist empty for now.
CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
• Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

• Is an E2E test/test case added for the new feature/change?
• Are unit tests added where appropriate?
• Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Are all needed new/changed options added to the Helm Chart?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported MongoDB version?
• Does the change support oldest and newest supported Kubernetes version?

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hors
❌ cshiv
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[egegunes]

@cshiv thank you for this PR. I only worry about the version label, because it needs to be updated with every release. @nmarukovich could you please update our Makefile to update this label automatically with make manifests, you can push your changes here and we'll merge this PR.

[hors]

@cshiv thank you for this PR. I only worry about the version label, because it needs to be updated with every release. @nmarukovich could you please update our Makefile to update this label automatically with make manifests, you can push your changes here and we'll merge this PR.

I do not like the version label as well because in our official doc to update operator you need to update CRDs, RBAC and then just patch the image in percona-server-mongodb-operator deployment. Now, we need to update the version label as well. I do not like it.

[cshiv]

@egegunes @hors I totally agree that maintaining version in every single release is a pain. I have added it as a reference. Please feel free to remove it :)

[gkech]

@cshiv we can remove the versions from all the resources since it will be a manual process to update them and we can avoid this since we don't really need it.

[gkech]

We can keep all the other labels and we are ready!

[cshiv]

Sounds good, lets do it

[hors]

@cshiv please remove app.kubernetes.io/version label and we will merge it.

[cshiv]

@hors Removed the version

[JNKPercona]

Test name	Status
arbiter	passed
balancer	passed
cross-site-sharded	failure
custom-replset-name	passed
custom-tls	passed
custom-users-roles	passed
custom-users-roles-sharded	passed
data-at-rest-encryption	passed
data-sharded	passed
demand-backup	passed
demand-backup-eks-credentials-irsa	passed
demand-backup-fs	passed
demand-backup-incremental	passed
demand-backup-incremental-sharded	passed
demand-backup-physical	passed
demand-backup-physical-sharded	passed
demand-backup-sharded	passed
expose-sharded	passed
finalizer	passed
ignore-labels-annotations	passed
init-deploy	passed
ldap	passed
ldap-tls	passed
limits	passed
liveness	passed
mongod-major-upgrade	passed
mongod-major-upgrade-sharded	passed
monitoring-2-0	passed
multi-cluster-service	passed
multi-storage	passed
non-voting	passed
one-pod	passed
operator-self-healing-chaos	passed
pitr	passed
pitr-physical	passed
pitr-sharded	passed
preinit-updates	passed
pvc-resize	passed
recover-no-primary	passed
replset-overrides	passed
rs-shard-migration	passed
scaling	passed
scheduled-backup	passed
security-context	passed
self-healing-chaos	passed
service-per-pod	passed
serviceless-external-nodes	failure
smart-update	passed
split-horizon	passed
stable-resource-version	passed
storage	passed
tls-issue-cert-manager	passed
upgrade	passed
upgrade-consistency	passed
upgrade-consistency-sharded-tls	passed
upgrade-sharded	passed
users	passed
version-service	passed
We run 58 out of 58

commit: 54911d4
image: perconalab/percona-server-mongodb-operator:PR-1776-54911d4c