Skip to content

K8SPSMDB-1265: clean up basmdb-backup and use kubectl wait for wait_restore #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 8, 2025

Conversation

eleo007
Copy link
Contributor

@eleo007 eleo007 commented May 6, 2025

K8SPSMDB-1265 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Hi. The following problems should be fixed:

  1. From time to time wait_restore() does not detect that object has requested state and fails, although eventually restore gets ready state.
  2. The presence of the backup in minio storage fails in demand-backup-sharded.
  3. The backups are not deleted from the storage after tests as a result resync requires a lot of time and tests run long.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:

  1. Use kubectl wait instead of regular loop.
  2. Add retry.
  3. Delete backups before removing finalizers from objects.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@eleo007 eleo007 requested a review from jvpasinatto as a code owner May 6, 2025 20:43
@pull-request-size pull-request-size bot added the size/M 30-99 lines label May 6, 2025
@eleo007 eleo007 marked this pull request as draft May 6, 2025 20:43
@github-actions github-actions bot added the tests label May 6, 2025
@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/M 30-99 lines labels May 7, 2025
@eleo007 eleo007 force-pushed the K8SPSMDB-1265-clean-backup branch 2 times, most recently from 0c7042e to 0badae8 Compare May 7, 2025 19:42
@eleo007 eleo007 force-pushed the K8SPSMDB-1265-clean-backup branch from 0badae8 to 7ff5073 Compare May 7, 2025 19:44
eleo007 and others added 8 commits May 7, 2025 22:45
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pull-request-size pull-request-size bot added size/M 30-99 lines and removed size/L 100-499 lines labels May 8, 2025
@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/M 30-99 lines labels May 8, 2025
@pull-request-size pull-request-size bot added size/M 30-99 lines and removed size/L 100-499 lines labels May 8, 2025
@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/M 30-99 lines labels May 8, 2025
@eleo007 eleo007 changed the title K8SPSMDB-1265: Delete psmdb-backups with namespace cleanup in tests K8SPSMDB-1265: clean up basmdb-backup and use kubectl wait for wait_restore May 8, 2025
@eleo007 eleo007 marked this pull request as ready for review May 8, 2025 14:46
@eleo007 eleo007 merged commit db64919 into release-1.20.0 May 8, 2025
18 of 19 checks passed
@eleo007 eleo007 deleted the K8SPSMDB-1265-clean-backup branch May 8, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L 100-499 lines tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants