PT-2298 pt-galera-log-explainer superfluous lines on conflicts #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gression test When adding "ownip", it was also propagating the new IP to the old hash. But with operators, when IP where changing hash will also change, so linking the new IP to old hash is anachronic. It is not wrong, but depending on the order of map merges, the newest information could have been overriden depending on the order of events. That situation was producing X(2*number of conflicts) versions of output for operators, with different md5sum, which could produce false-positive regression tests So currently some information are not linked anymore, so some IPs are not translated even though they could, but it is a limitation of using maps as source of truth, as they are not versioned
It must test multiple times to remove doubts. As the tool is reading files and relying on maps, their access order are random. It can impact some translations
It existed for non-operator setup, but was not working for operators due to k8s logs not interpreting newlines and tabs This operator version re-uses existing regular regex handlers directly
It was using maps in each context, which would be merged between contexts, then injected each time we needed a message to display. It had a limitation on complicated operator setups: historical information would be overriden by newer associations. (e.g, that IP was for node0 yesterday, now it's node1, so associations have been overwritten and incorrect) It also introduced complexity, such as forcing to define closures too many times, merging maps, it would be harder to debug, and every files were starting from empty translation maps. Moreover, iterating on maps is guaranteed to be random so it could create hard-to-debug output variations on complex cases. Now it is a singleton in translate package, still using maps but now it associates an array of "units" storing the timestamp with each piece of information. It is protected by rwmutex, because map are not threadsafe. (there's no parallel processing for now) No regressions, and it passes "operator_ambiguous_ips_list_all_no_color" where the old system failed. It nows also can be used as an easy to read source of information in itself
Can be used to break the tool, and I actually never had an use-case
- Commented out whois command in README.rst - Copied README.rst into docs directory, so user manual will include this tool
Co-authored-by: Sveta Smirnova <[email protected]>
- Sync README.rst and docs/pt-galera-log-explainer.rst
- Added exception for IST into .typos.toml
- Added exception into .typos.toml for src/go/pt-galera-log-explainer/tests/
- Added exception for Go tests into .typos.toml
- Exceptions for identifiers and Galera library errors in .typos.toml
Add pt-galera-log-explainer
Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.30.0 to 1.31.0. - [Release notes](https://github.com/rs/zerolog/releases) - [Commits](rs/zerolog@v1.30.0...v1.31.0) --- updated-dependencies: - dependency-name: github.com/rs/zerolog dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.9 to 0.6.0. - [Release notes](https://github.com/google/go-cmp/releases) - [Commits](google/go-cmp@v0.5.9...v0.6.0) --- updated-dependencies: - dependency-name: github.com/google/go-cmp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…_testcase Follow PR-429 unstop option with testcase
PT-2277 - fix pt-visual-explain for 'Impossible ON condition' case
…/google/go-cmp-0.6.0 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0
…/rs/zerolog-1.31.0 Bump github.com/rs/zerolog from 1.30.0 to 1.31.0
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.16.0. - [Commits](golang/crypto@v0.15.0...v0.16.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…/x/crypto-0.16.0 Bump golang.org/x/crypto from 0.15.0 to 0.16.0
- Changed logic, introduced by commit 1d1c13f - Added test case
…QL8.0" This reverts commit 284a1f9.
- Changed logic, introduced by commit 1d1c13f - Added test case
- Run util/update-modules
…r_id 0 - Better check if server_id is defined - Added test case
Bumps [go.mongodb.org/mongo-driver](https://github.com/mongodb/mongo-go-driver) from 1.13.0 to 1.13.1. - [Release notes](https://github.com/mongodb/mongo-go-driver/releases) - [Commits](mongodb/mongo-go-driver@v1.13.0...v1.13.1) --- updated-dependencies: - dependency-name: go.mongodb.org/mongo-driver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.14.0 to 0.16.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.14.0...0.16.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…s/setup-go-5 Bump actions/setup-go from 4 to 5
…curity/trivy-action-0.16.0 Bump aquasecurity/trivy-action from 0.14.0 to 0.16.0
….org/mongo-driver-1.13.1 Bump go.mongodb.org/mongo-driver from 1.13.0 to 1.13.1
…tion_is_not_working_for_MySQL8.0 PT-2083 - Pt-archiver --charset option is not working for MySQL8.0
…3.5.5_breaks_on_mysql5.7_with_server_id_0 PT-2268 - pt-online-schema-change 3.5.5 breaks on mysql5.7 with serve…
Added hook for help output for new option in src/go/Makefile: build
Updated modules and version
svetasmirnova
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It actually was the broken example on blog post's draft.