-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-12468 Plan summary, COLLSCAN. #920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add regression tests.
@svetasmirnova where can we find CI tests execution results? |
I expect you to add tests to src/go/mongolib/proto/system.profile_test.go and src/go/mongolib/stats/stats_test.go and run those tests locally when change code. Proper testing for Go tools is planned but not done yet. |
The stats_test.go tests are currently completely skipped (even locally). The system.profile_test.go tests, which check explain and my changes about plan summary, are not related to it. Due to the issues mentioned above, I created a ticket: Additionally, I corrected some other tests, such as: Would you agree to merge this PR and cover my changes with tests in the ticket, where we will fix the stats tests and related issues together? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, approving it now. Let's fix tests in https://perconadev.atlassian.net/browse/PT-2423
Ticket on PMM side: https://perconadev.atlassian.net/browse/PMM-12468