Skip to content

PMM-9541 Fix database discover when using socket #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2023
Merged

PMM-9541 Fix database discover when using socket #118

merged 1 commit into from
May 8, 2023

Conversation

0leksii
Copy link

@0leksii 0leksii commented Apr 25, 2023 •
edited
Loading

When discovering databases and using local socket connection add trailing "/" to the database name to omit using it as a host for the connection.

Feature build:

@0leksii
PMM-9541 Fix database discover when using socket
75c0164 
When discovering databases and using local socket connection add
trailing "/" to the database name to omit using it as a host for
the connection.
@0leksii 0leksii requested a review from a team as a code owner April 25, 2023 13:18
@0leksii 0leksii requested review from tshcherban and IuriiMr April 25, 2023 13:18
@it-percona-cla
Copy link

it-percona-cla commented Apr 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@0leksii 0leksii temporarily deployed to CI April 25, 2023 13:18 — with GitHub Actions Inactive
@0leksii 0leksii temporarily deployed to CI April 25, 2023 13:18 — with GitHub Actions Inactive
@0leksii 0leksii temporarily deployed to CI April 25, 2023 13:18 — with GitHub Actions Inactive
@0leksii 0leksii temporarily deployed to CI April 25, 2023 13:18 — with GitHub Actions Inactive
@0leksii 0leksii temporarily deployed to CI April 25, 2023 13:18 — with GitHub Actions Inactive
@0leksii 0leksii requested review from pkadej and ritbl April 25, 2023 13:19
@0leksii 0leksii mentioned this pull request Apr 25, 2023
Closed
@0leksii 0leksii requested a review from JiriCtvrtka April 26, 2023 13:03
IuriiMr
IuriiMr approved these changes May 2, 2023
View reviewed changes
Copy link

@IuriiMr IuriiMr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice for me to ensure that the dsnURI contains the correct information for connecting to a database.

@0leksii 0leksii merged commit c3fbc44 into main May 8, 2023
@0leksii 0leksii deleted the PMM-9541-fix-socket-connection branch May 8, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkadej pkadej pkadej approved these changes

@IuriiMr IuriiMr IuriiMr approved these changes

@tshcherban tshcherban Awaiting requested review from tshcherban tshcherban is a code owner automatically assigned from percona/pmm-review-exporters

@ritbl ritbl Awaiting requested review from ritbl

@JiriCtvrtka JiriCtvrtka Awaiting requested review from JiriCtvrtka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0leksii @it-percona-cla @pkadej @IuriiMr