Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS-9197 [DOCS] - add JS stored routines 8.4 #473

Merged
merged 1 commit into from
Mar 19, 2025
Merged

PS-9197 [DOCS] - add JS stored routines 8.4 #473

merged 1 commit into from
Mar 19, 2025

Conversation

patrickbirch
Copy link
Collaborator

new file:   docs/js-lang-overview.md
new file:   docs/js-lang-privileges.md
new file:   docs/js-lang-procedures.md
new file:   docs/js-lang-troubleshoot.md
new file:   docs/uninstall-js-lang.md
modified:   mkdocs-base.yml

Copy link
Collaborator

@dlenev dlenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Patrick!

I have a few comments about proposed documentation.

Copy link
Collaborator

@dlenev dlenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Patrick!

I have only one comment about the table describing JS to SQL data type conversion.

	new file:   docs/js-lang-overview.md
	new file:   docs/js-lang-privileges.md
	new file:   docs/js-lang-procedures.md
	new file:   docs/js-lang-troubleshoot.md
	new file:   docs/uninstall-js-lang.md
	modified:   mkdocs-base.yml
@alina-derkach-oaza alina-derkach-oaza temporarily deployed to 9197 - percona-server-docs-8.4 PR #473 March 19, 2025 10:38 — with Render Destroyed
@patrickbirch patrickbirch requested a review from dlenev March 19, 2025 10:38
Copy link
Collaborator

@dlenev dlenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Patrick!

Looks OK to me!

@patrickbirch patrickbirch merged commit 7416046 into 8.4 Mar 19, 2025
@patrickbirch patrickbirch deleted the 9197 branch March 19, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants