Skip to content

プレビューが作成されるタイミングから push を削除 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2020

Conversation

odanado
Copy link
Contributor

@odanado odanado commented May 7, 2020

プルリクの作成時と更新時のみでプレビューが作成されるように変更しました

これまではプルリクのない状態の push 時にも作成されていました。しかし、この状態ではコメントが二重に作成されてしまうことと、プレビュー作成はプルリクができるまで待っても問題がないという判断から、削除しました。

@odanado
Copy link
Contributor Author

odanado commented May 7, 2020

文脈: #27 (comment)

@github-actions
Copy link

github-actions bot commented May 7, 2020

@kfly8
Copy link
Contributor

kfly8 commented May 10, 2020

LGTM

@kfly8 kfly8 merged commit 9915b55 into content May 10, 2020
@kfly8 kfly8 deleted the fix-netlify-event branch May 10, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants