-
-
Notifications
You must be signed in to change notification settings - Fork 0
docs: expand JIRA integration instructions #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning Rate limit exceeded@patinthehat has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 25 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughExpanded README.md's JIRA Integration with a new "Configuration" subsection: step-by-step guidance to create/store a JIRA API token, required env vars ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for improving the JIRA integration documentation! The changes make the setup process much clearer with step-by-step instructions. I've suggested a few enhancements:
- Adding security best practices for credential storage
- Including an example of the expected branch name format with JIRA issue key
- Adding cache-related details for troubleshooting
Overall, this is a good improvement to the documentation that will help users set up the JIRA integration more easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
138-138: Line length
Expected: 160; Actual: 256
(MD013, line-length)
🔇 Additional comments (3)
README.md (3)
140-140: Section header reads wellClear entry point for users. No changes needed.
146-147: Good step breakdownStep title is clear. Proceeding comments focus on the env block below.
156-160: Usage example looks goodCommand and flag are correct and consistent with earlier context.
Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
♻️ Duplicate comments (2)
README.md (2)
162-162: Clarify cache behavior and remove numeric bias language.The phrase "higher numbers" implies that issue number is a ranking factor, which is misleading. Also clarify whether the 5-minute TTL is fixed or configurable.
Apply this diff:
-Results are cached for five minutes to avoid repeated API calls. Tickets with higher numbers that have been updated recently are ranked above older or inactive issues. +Results are cached for 5 minutes to avoid repeated API calls. +Recently updated issues rank higher; inactive or older issues rank lower.If the cache TTL is configurable, add a line documenting the flag or environment variable name.
138-139: Reword for clarity, Atlassian branding, and line length compliance.Line 138 exceeds MD013 (256 chars vs. 160 limit), uses "JIRA" (Atlassian's brand is "Jira"), and could be more concise. Rewording also addresses past review feedback.
Apply this diff:
-The `branch:recent` command can be run with the `--jira` flag to refine the ordering of the results using live data from JIRA. When your branch names include a JIRA issue key, branches tied to active issues you've updated recently appear closer to the top. +The `branch:recent` command can be run with the `--jira` flag to refine ordering +using live data from Jira. + +When branch names include a Jira issue key, branches tied to issues you updated +recently appear near the top.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
146-146: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
147-147: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above
(MD022, blanks-around-headings)
147-147: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
150-150: Bare URL used
(MD034, no-bare-urls)
151-151: Bare URL used
(MD034, no-bare-urls)
152-152: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
152-152: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
156-156: Ordered list item prefix
Expected: 2; Actual: 3; Style: 1/2/3
(MD029, ol-prefix)
patinthehat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
|
@patinthehat I've opened a new pull request, #30, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Co-authored-by: patinthehat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
README.md (1)
138-138: Use Atlassian's official "Jira" branding instead of "JIRA".Line 138 uses the outdated all-caps "JIRA"; Atlassian's current branding standard is "Jira".
-The `branch:recent` command can be run with the `--jira` flag to refine the ordering of the results using live data from JIRA. When your branch names include a JIRA issue key, branches tied to active issues you've updated recently appear closer to the top. +The `branch:recent` command can be run with the `--jira` flag to refine the ordering of the results using live data from Jira. When your branch names include a Jira issue key, branches tied to active issues you've updated recently appear closer to the top.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
157-157: Ordered list item prefix
Expected: 1; Actual: 3; Style: 1/1/1
(MD029, ol-prefix)
[WIP] Update JIRA integration instructions in README.md
This pull request improves the documentation for the JIRA integration in the
README.mdfile, making it more detailed and user-friendly. The update provides step-by-step configuration instructions and clarifies how the--jiraflag affects branch ordering.Documentation improvements:
README.mdto include clear, step-by-step setup instructions for creating an API token, setting environment variables, and running the command with the--jiraflag.--jiraflag affects branch ordering and added information about result caching and ranking logic.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.