[ENHANCEMENT] Inject the same prom registry in the metrics api than in the echo server #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in the echo server Signed-off-by: Augustin Husson <[email protected]>
Nexucis
force-pushed
the
nexucis/fix-prom-registry
branch
from
240b603 to
946c8fa
Compare
Signed-off-by: Augustin Husson <[email protected]>
Nexucis
changed the title
celian-garcia
requested changes
Apr 17, 2024
Signed-off-by: Augustin Husson <[email protected]>
celian-garcia
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
echoserver, it's possible to inject a custom Prometheus metrics registry. But if it was used, then metrics collected wasn't exposed in/metricssince the Metric API didn't consider this custom metrics registry.This PR aims to fix that. But in the meantime it introduced a breaking change ... If someone has a better idea, I would be glad to hear it