Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated contenders json file format #121

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Updated contenders json file format #121

wants to merge 2 commits into from

Conversation

souravtecken
Copy link
Contributor

@souravtecken souravtecken commented Jun 29, 2019 •
edited
Loading

  1. Updated parsing of json according the current format in SignupForm.js
  2. Added console log statements for errors in contests.js and admin.js

@adityavinodk
Copy link
Collaborator

Kindly also note down the list of the users which weren't found and display them as either as a pop-up or in the console itself. Also kindly add the same functionality to Signup and Create Group endpoints.

Please add a description to the Pull Requests.

@souravtecken
Added log statements for errors.
168af5b 
1. Added console log statements for error messages.
@adityavinodk adityavinodk requested a review from aniketnk July 3, 2019 04:43
@aniketnk
Copy link
Collaborator

aniketnk commented Jul 6, 2019

This is great!
Could you also display the failed requests in the frontend?

@aniketnk aniketnk changed the base branch from master to development July 6, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketnk aniketnk Awaiting requested review from aniketnk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@souravtecken @adityavinodk @aniketnk