Restructure front end for new course/assignment/signup flow. #127
+1,526
−540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added signup option in the navbar dropdown. 2. Seperated courseCards for courseAdmin/(Student/CourseMember) 3. Seperated courseView pages for the same. 4. Added requestCourse option in courses page. 5. courseMember can add assignments within a courseCard. 6. Added professor list reducer (For retrieving list of teaching members in courseAdminCard) Course component hierarchy: - CoursesContainer (Conditional renders either of the following two views) - CoursesAdminView (contains handleApproveCourse, handleRejectCourse methods) - CourseCardAdmin (Card for course request) - CourseView (contains handleActivateCourse, handleRequestCourse methods) - CourseCard (Card for teaching members/student, contains handleCreateAssignment method) profReducer: - Action: FETCHED_PROFS - adds list of teacher objects (containing ID and name) to store. - Action: CLEARED_PROFS - Clears teachers from store.
1. Added comment, removed tags from user object in response. 2. Updated route used to fetch teacher details.
adityavinodk
requested changes
Sep 9, 2019
adityavinodk
approved these changes
Sep 17, 2019
-> Updated to allow adding of different classes with respective teaching members and sections.
-> Added student/prof selector with role in courseAdminCard -> Improved signup form appearance -> Added collegeMember reducer for students and professors, replacing previous prof reducer. -> Added validation on frontend in courseAdmin flow. (For grad year, addition of classes, selecting of teaching members) -> Minor UI changes -> TODO: Replace toasts with alerts
-> Added graduatingYear to course schema -> Moved graduatingYear picker for each class from course as a whole -> Course Admin card shows selected teaching members outside the selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Course component hierarchy:
collegeMembersReducer:
- adds list of student objects (containing ID and name) to store.