Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WebAssembly targets #111

Merged
merged 5 commits into from
May 18, 2024
Merged

Support WebAssembly targets #111

merged 5 commits into from
May 18, 2024

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented May 14, 2024

Being WebAssembly is progressing at a fast pace, the more WASM-enabled libraries, the better.

Updating to 1.9.24 is required for using Node.js 22.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (06b7c72) to head (3aae232).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #111      +/-   ##
============================================
+ Coverage     84.17%   84.26%   +0.09%     
  Complexity      151      151              
============================================
  Files            22       22              
  Lines           537      534       -3     
  Branches         89       89              
============================================
- Hits            452      450       -2     
+ Misses           58       57       -1     
  Partials         27       27              
Flag Coverage Δ
unittests 84.26% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


The supported Native targets are:

| Tier 1 | Tier 2 | Tier 3 |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by tiers here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table aligns with the tiers specified in the documentation:
https://kotlinlang.org/docs/native-target-support.html

I'd like to enable other Native targets in the future.

Copy link
Owner

@petertrr petertrr May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I missed the inception of this classification! Could you please add think link to the readme as well, something like:

Suggested change
| Tier 1 | Tier 2 | Tier 3 |
The supported Native targets are (following the Kotlin/Native [target support guidelines](https://kotlinlang.org/docs/native-target-support.html)):
| Tier 1 | Tier 2 | Tier 3 |

Edit: I updated it myself to merge the PR quicker

@petertrr petertrr enabled auto-merge (squash) May 18, 2024 13:30
@petertrr petertrr merged commit 875f4ce into petertrr:main May 18, 2024
3 checks passed
@lppedd lppedd deleted the build/wasm branch May 22, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants