Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ARM cpu targets #115

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

dobe
Copy link
Contributor

@dobe dobe commented Jun 19, 2024

No description provided.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.07%. Comparing base (2e5d985) to head (840e5c1).

Current head 840e5c1 differs from pull request most recent head 21f9c47

Please upload reports for the commit 21f9c47 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #115   +/-   ##
=========================================
  Coverage     86.07%   86.07%           
  Complexity      221      221           
=========================================
  Files            30       30           
  Lines           632      632           
  Branches        117      117           
=========================================
  Hits            544      544           
  Misses           59       59           
  Partials         29       29           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lppedd
Copy link
Contributor

lppedd commented Jun 19, 2024

What about adding all native targets?
Since @petertrr already deploys Apple targets, it should be possible to activate all of them (Tier 1/2/3).

Just need to be careful with automation, to avoid testing the same stuff 20 times.

@dobe
Copy link
Contributor Author

dobe commented Jun 20, 2024

@lppedd i agree with you, however as you say, i am also not aware about the overhead that is introduced here when adding additional targets. So I was adding just the ones that i currently need since i actually tested these. @petertrr please see this merely as a request to add at least those targets. Thanks upfront.

Copy link
Owner

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's fine for me to add only these for now, and add additional targets later with a more careful look at tests and infrastructure

@petertrr
Copy link
Owner

@dobe could you also update the list of targets in the readme (or enable editing of the PR by maintainers)?

@dobe dobe force-pushed the dobe/add-arm-targets branch from 840e5c1 to 21f9c47 Compare June 21, 2024 04:32
@petertrr petertrr merged commit b90ea21 into petertrr:main Jun 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants