Replace FindPHPSystem.cmake with FindPHP.cmake #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
force-pushed
the
patch-find-php
branch
2 times, most recently
from
5f09256 to
11e2ad3
Compare
petk
changed the title
petk
force-pushed
the
patch-find-php
branch
2 times, most recently
from
d853ae9 to
717fc45
Compare
This renames the weird PHPSystem to simply PHP, however it may clash with variables set by `project(PHP)`, so the `find_package()` is wrapped in the `block()` and propagates PHP_FOUND. The PHP_EXECUTABLE is cache variable, so it's available outside of the block as expected.
This enables using the same find module in various scenarios: - building PHP extension with CMake - building application with embedded PHP - finding only PHP executable
This adds the config files for finding PHP when using find_package(PHP) without find module (the CONFIG mode). Further improvements and refactorings in the next commits...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the weird PHPSystem to simply PHP, however it may clash with variables set by
project(PHP), so thefind_package()is wrapped in theblock()and propagatesPHP_FOUNDresult variable. ThePHP_EXECUTABLEis cache variable, so it's available outside of the block as expected. ThePHP_FOUNDis used in case when the found PHP version is not sufficient. In such case thePHP_EXECUTABLEwill still be set.