Replace Install.cmake with InstallDirs.cmake #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the hacky `php_install()` command and uses CMake's `install()` commands on the account of some `PHP_INSTALL_*` variables that bypass current issues for GNU special cases mentioned in the `GNUInstallDirs` module. * The `php_configure_file()` is also replaced with only core CMake commands. The hacky php_configure_file is ok and works for its use cases, but realistically, any custom module increases the difficulty to understand the build system. On the expense of more complex code, this uses only core CMake commands - install(), configure_file(), etc. Also, `install(CODE)` supports generator expressions if they are needed in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the hacky
php_install()command and uses CMake'sinstall()commands on the account of somePHP_INSTALL_*variables that bypass current issues for GNU special cases mentioned in theGNUInstallDirsmodule.The
php_configure_file()is also replaced with only core CMake commands.The hacky
php_configure_file()is OK and works for its use cases, but realistically, any custom module increases the difficulty to understand the build system. On the expense of more complex code, this uses only core CMake commands -install(),configure_file(), etc. Also,install(CODE)supports generator expressions if they are needed in some cases.