-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCKER: removed deprecated docker containers and references #1555
DOCKER: removed deprecated docker containers and references #1555
Conversation
Shall we aswell move the content of |
Containters ~= Docker. I'm where I prefer the Then rename Just to chime in. 😅 |
Sure - that makes sense. Also I believe I deleted RELEASE.md yesterday - that file is no longer needed. I like having Dockerfile in the root directory too but we also have the entrypoint.sh, docker compose files and the README so better off in a subdirectory for now. |
Also I pushed 764c0ef to master to update the entrypoint.sh link to documentation. You probably want to update this branch to sync with master when you can. |
I agree. Lets keep it in this sub dir for now. |
e38f23e
to
1a9d619
Compare
I'll try to keep this draft in sync to master until support for the obsolete containers finally will be dropped |
@pglombardo But since it is not directly related to this PR it can be updated anyway. |
Now I see you already did - perfect.
By all means, feel free/thanks. |
What I wrote was a bit confusing. I just wanted to agree to your suggestion.
Done. |
1a9d619
to
d527bfa
Compare
Hey @sirux88 - whenever you can let's merge this. ...time to clean up and get rid of the old stuff. |
d527bfa
to
bbbccbc
Compare
@pglombardo: I rebased to current master. Aswell I rescanned for any obsolete references but didn't find any. So this should be ready for merging |
@pglombardo: Maybe we should change the depracation notice like this one for the old images into a end of support notice build, let the images be built and pushed to docker hub. Let me know if you want to do this. I'll throw another PR then. Afterwards we could merge this PR. |
Ah good point - that's a great idea. Let's do that by all means. |
bbbccbc
to
7b103fd
Compare
should be ready for merge now @pglombardo |
And with that merge, it concludes the final move to the universal container. Thanks to both of you for the input and contributions to get to this point! |
…do#1555) * removed obsolete docker containers and references * Move container files up a level and fix references * fix some text references * fix dependabot action * fix out-of-context links
Description
This PR should contain all the necessary steps to remove the deprecated docker container images with its references from the repo.
This is related to the introduction of the new unified/universal docker container image (PR see below)
Aswell this is meant to be WIP until support for these deprecated images will be dropped.
Related Issue
#1369
Type of Change
Checklist
rake test
)