Skip to content

Commit 0a32774

Browse files
authored
Merge pull request #54 from phac-nml/dev
merging dev into main
2 parents 88e9764 + 8662ca1 commit 0a32774

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+1959
-3436
lines changed

.gitattributes

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,3 @@
22
*.nf.test linguist-language=nextflow
33
modules/nf-core/** linguist-generated
44
subworkflows/nf-core/** linguist-generated
5-

.github/workflows/branch.yml.bak renamed to .github/workflows/branch.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
11
name: nf-core branch protection
22
# This workflow is triggered on PRs to master branch on the repository
3-
# It fails when someone tries to make a PR against the nf-core `master` branch instead of `dev`
3+
# It fails when someone tries to make a PR against the `main` branch instead of `dev`
44
on:
55
pull_request_target:
6-
branches: [master]
6+
branches: [main]
77

88
jobs:
99
test:
1010
runs-on: ubuntu-latest
1111
steps:
1212
# PRs to the nf-core repo master branch are only ok if coming from the nf-core repo `dev` or any `patch` branches
1313
- name: Check PRs
14-
if: github.repository == 'mk-kondo/mikrokondo'
14+
if: github.repository == 'phac-nml/mikrokondo'
1515
run: |
16-
{ [[ ${{github.event.pull_request.head.repo.full_name }} == mk-kondo/mikrokondo ]] && [[ $GITHUB_HEAD_REF = "dev" ]]; } || [[ $GITHUB_HEAD_REF == "patch" ]]
16+
{ [[ ${{github.event.pull_request.head.repo.full_name }} == phac-nml/mikrokondo ]] && [[ $GITHUB_HEAD_REF == "dev" ]]; } || [[ $GITHUB_HEAD_REF == "patch" ]]
1717
1818
# If the above check failed, post a comment on the PR explaining the failure
1919
# NOTE - this doesn't currently work if the PR is coming from a fork, due to limitations in GitHub actions secrets
2020
- name: Post PR comment
2121
if: failure()
22-
uses: mshick/add-pr-comment@v1
22+
uses: mshick/add-pr-comment@b8f338c590a895d50bcbfa6c5859251edc8952fc # v2
2323
with:
2424
message: |
25-
## This PR is against the `master` branch :x:
25+
## This PR is against the `main` branch :x:
2626
2727
* Do not close this PR
2828
* Click _Edit_ and change the `base` to `dev`
@@ -32,9 +32,9 @@ jobs:
3232
3333
Hi @${{ github.event.pull_request.user.login }},
3434
35-
It looks like this pull-request is has been made against the [${{github.event.pull_request.head.repo.full_name }}](https://github.com/${{github.event.pull_request.head.repo.full_name }}) `master` branch.
36-
The `master` branch on nf-core repositories should always contain code from the latest release.
37-
Because of this, PRs to `master` are only allowed if they come from the [${{github.event.pull_request.head.repo.full_name }}](https://github.com/${{github.event.pull_request.head.repo.full_name }}) `dev` branch.
35+
It looks like this pull-request is has been made against the [${{github.event.pull_request.head.repo.full_name }}](https://github.com/${{github.event.pull_request.head.repo.full_name }}) `main` branch.
36+
The `main` branch on nf-core repositories should always contain code from the latest release.
37+
Because of this, PRs to `main` are only allowed if they come from the [${{github.event.pull_request.head.repo.full_name }}](https://github.com/${{github.event.pull_request.head.repo.full_name }}) `dev` branch.
3838
3939
You do not need to close this PR, you can change the target branch to `dev` by clicking the _"Edit"_ button at the top of this page.
4040
Note that even after this, the test will continue to show as failing until you push a new commit.

.github/workflows/ci.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- "latest-everything"
2929
steps:
3030
- name: Check out pipeline code
31-
uses: actions/checkout@v3
31+
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
3232

3333
- name: Install Nextflow
3434
uses: nf-core/setup-nextflow@v1
@@ -50,8 +50,14 @@ jobs:
5050
wget -qO- https://code.askimed.com/install/nf-test | bash
5151
sudo mv nf-test /usr/local/bin/
5252
53+
- name: Disk space cleanup
54+
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
55+
5356
- name: Run nf-test
5457
run: |
5558
nf-test test
5659
60+
- name: Nextflow run with test profile
61+
run: |
62+
nextflow run ${GITHUB_WORKSPACE} -profile test,docker --outdir ./results
5763

.github/workflows/fix-linting.yml.orig

Lines changed: 0 additions & 55 deletions
This file was deleted.

.github/workflows/linting.yml

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
name: nf-core linting
2+
# This workflow is triggered on pushes and PRs to the repository.
3+
# It runs the `nf-core lint` and markdown lint tests to ensure
4+
# that the code meets the nf-core guidelines.
5+
on:
6+
push:
7+
branches:
8+
- dev
9+
pull_request:
10+
release:
11+
types: [published]
12+
13+
jobs:
14+
pre-commit:
15+
runs-on: ubuntu-latest
16+
steps:
17+
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
18+
19+
- name: Set up Python 3.11
20+
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5
21+
with:
22+
python-version: 3.11
23+
cache: "pip"
24+
25+
- name: Install pre-commit
26+
run: pip install pre-commit
27+
28+
- name: Run pre-commit
29+
#run: pre-commit run --all-files
30+
run: pre-commit run --files nf-test.config
31+
32+
nf-core:
33+
runs-on: ubuntu-latest
34+
steps:
35+
- name: Check out pipeline code
36+
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
37+
38+
- name: Install Nextflow
39+
uses: nf-core/setup-nextflow@v1
40+
41+
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5
42+
with:
43+
python-version: "3.11"
44+
architecture: "x64"
45+
46+
- name: Install dependencies
47+
run: |
48+
python -m pip install --upgrade pip
49+
pip install nf-core
50+
51+
- name: Run nf-core lint
52+
env:
53+
GITHUB_COMMENTS_URL: ${{ github.event.pull_request.comments_url }}
54+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
55+
GITHUB_PR_COMMIT: ${{ github.event.pull_request.head.sha }}
56+
run: nf-core -l lint_log.txt lint --dir ${GITHUB_WORKSPACE} --markdown lint_results.md
57+
58+
- name: Save PR number
59+
if: ${{ always() }}
60+
run: echo ${{ github.event.pull_request.number }} > PR_number.txt
61+
62+
- name: Upload linting log file artifact
63+
if: ${{ always() }}
64+
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4
65+
with:
66+
name: linting-logs
67+
path: |
68+
lint_log.txt
69+
lint_results.md
70+
PR_number.txt

.github/workflows/linting.yml.orig

Lines changed: 0 additions & 108 deletions
This file was deleted.

.github/workflows/linting_comment.yml.orig

Lines changed: 0 additions & 28 deletions
This file was deleted.

.github/workflows/stub.yml.orig

Lines changed: 0 additions & 46 deletions
This file was deleted.

0 commit comments

Comments
 (0)