[CompileGuard] Fix CompileGuardSelect#1294
Open
rsetaluri wants to merge 5 commits into
Open
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1294 +/- ##
==========================================
+ Coverage 85.83% 85.87% +0.03%
==========================================
Files 164 164
Lines 17544 17567 +23
==========================================
+ Hits 15059 15085 +26
+ Misses 2485 2482 -3
|
leonardt
requested changes
Jul 28, 2023
| m.compile(f"build/{basename}", _Top, inline=True) | ||
| assert m.testing.check_files_equal( | ||
| __file__, f"build/{basename}.v", f"gold/{basename}.v" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Should we update these to use mlir/mlir-verilog instead of coreir? Will save us doing it in the future.
Collaborator
Author
There was a problem hiding this comment.
Will do these in a follow up PR.
See #1291. Fixes two-key case (previously unsupported), and adds and refactors tests.
rsetaluri
force-pushed
the
compile-guard-select-fix
branch
from
2e5e2a9 to
b8f9456
Compare
rsetaluri
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1291.