Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #268: admiralmetabolic release announcment #269

Merged
merged 14 commits into from
Jan 21, 2025

Conversation

manciniedoardo
Copy link
Collaborator

@manciniedoardo manciniedoardo commented Jan 20, 2025

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Ensure your new post folder is of the form "posts/zzz_DO_NOT_EDIT_<your post title>". This is so that the post date can be auto-updated upon the merge into main.
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@manciniedoardo manciniedoardo changed the title Closes #268: admiralmetabolic release announcment first draft Closes #268: admiralmetabolic release announcment Jan 20, 2025
Copy link
Collaborator

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great post, great package, minor comments :)

Copy link
Member

@AndersAskeland AndersAskeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I have some suggestions for changes.

@manciniedoardo
Copy link
Collaborator Author

@AndersAskeland @StefanThoma thanks for your reviews. I think i've implemented everything 😄

Copy link
Member

@AndersAskeland AndersAskeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have these small ones, but besides that looking good! 🥇

@bms63
Copy link
Collaborator

bms63 commented Jan 21, 2025

my only ask - can we not use a ! in the file name please?

@manciniedoardo
Copy link
Collaborator Author

my only ask - can we not use a ! in the file name please?

Of course, now updated thanks

@manciniedoardo manciniedoardo merged commit 1ee6549 into main Jan 21, 2025
4 of 5 checks passed
@manciniedoardo manciniedoardo deleted the 268_admiralmetabolic_01 branch January 21, 2025 13:37
Copy link
Collaborator

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants