Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New ARD]: Table 35 (add gtsummary and ARD) #244

Open
7 tasks
aassuied-ps opened this issue Nov 25, 2024 · 3 comments · May be fixed by #247
Open
7 tasks

[New ARD]: Table 35 (add gtsummary and ARD) #244

aassuied-ps opened this issue Nov 25, 2024 · 3 comments · May be fixed by #247
Assignees
Labels

Comments

@aassuied-ps
Copy link
Collaborator

Table Layout & Design

See this issue: #176

Table Description

Same as #176

Analysis Datasets

ADSL, ADAE

Data from the random.cdisc.data package, can be retrieved by random.cdisc.data::c followed by your
dataset name.

Analysis Filters

Safety population: SAFFL == "Y"

Additional Information

No response

Developer To Dos

  • Table Function: Create R/fda-table_XX.R file with your table-generating function.
    • Roxygen Documentation: title, @details, document all parameters, @return, @examples, @export.
  • Tests: Create tests/testthat/test-table_XX.R file with tests for the table function and then run these tests.
  • Quarto Template: Create quarto/table-templates/template-table_XX.qmd file your table template.
  • Screenshot: Add table screenshot as table_XX.png to the quarto/assets/images/screenshots folder.
  • _quarto.yml: Add template to the "Template Library" section of the _quarto.yml file.
  • Template Index: Run quarto/assets/generate-template_index.R script to update the template index.
@aassuied-ps aassuied-ps added the new template Adding a new table template label Nov 25, 2024
@aassuied-ps aassuied-ps self-assigned this Nov 25, 2024
@aassuied-ps aassuied-ps added ARD and removed new template Adding a new table template labels Nov 25, 2024
@aassuied-ps
Copy link
Collaborator Author

aassuied-ps commented Nov 25, 2024

It appears gtsummary::add_overall() is not compatible with tbl_hierarchical objects. It is the same when I try to go from an ard_hierarchical to a tbl_hierarchical object.

I wanted to use cards::ard_stack_hierarchical but I think the overall argument is not fully compatible with gtsummary::tbl_ard_hierarchical yet.

@edelarua
Copy link
Collaborator

The add_overall() method for tbl_hierarchical objects was just recently added into {gtsummary}. If you'd like to try it out you can install development version 2.0.3.9006 or later and it should work. We don't need to add in any functionality/arguments for that since users can easily apply it themselves after creating the table if they'd like.

tbl_ard_hierarchical() is still under development and will undergo big changes in the near future, including the addition of the overall_row argument, but for now it may be easier not to use it.

@aassuied-ps
Copy link
Collaborator Author

On my current branch i used another way to deal with the overall column if you want to take a look. I will try to install the latest development version of gtsummary and use it this week.

@aassuied-ps aassuied-ps linked a pull request Jan 17, 2025 that will close this issue
@aassuied-ps aassuied-ps linked a pull request Jan 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants