Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

244 new ard table 35 add gtsummary and ard #247

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

aassuied-ps
Copy link
Collaborator

Pull Request

Closes #244

@aassuied-ps aassuied-ps linked an issue Jan 17, 2025 that may be closed by this pull request
7 tasks
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
fda-table_35 💔 $1.21$ $+2.71$ $+16$ $+2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
fda-table_35 👶 $+0.90$ Table_35_generation_works_with_gtsummary_missing_values
fda-table_35 👶 $+0.88$ Table_35_generation_works_with_gtsummary_with_custom_values

Results for commit f3584cf

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Unit Tests Summary

  1 files   30 suites   1m 24s ⏱️
139 tests 138 ✅   0 💤 0 ❌ 1 🔥
512 runs  380 ✅ 131 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit 16121b3.

♻️ This comment has been updated with latest results.

@aassuied-ps
Copy link
Collaborator Author

I used expect_error() on line 17 of the test file to avoid the following error:

Error: `everything()` must be used within a *selecting* function.
ℹ See <https://tidyselect.r-lib.org/reference/faq-selection-context.html> for details.

Code:
expect_error(expect_identical(res$table, res2))

I don't understand why this error occures.

@jknizia jknizia self-requested a review March 6, 2025 07:11
@jknizia
Copy link
Collaborator

jknizia commented Mar 12, 2025

Hi @ayogasekaram, this is the same test failing here as for your branch, is it? I have approved this PR (after making few updates), but we can only merge once the test passes. Could you please let me know in case you have already figured out the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New ARD]: Table 35 (add gtsummary and ARD)
2 participants