Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website updates #229

Merged
merged 15 commits into from
Jul 4, 2024
Merged

Website updates #229

merged 15 commits into from
Jul 4, 2024

Conversation

edelarua
Copy link
Collaborator

@edelarua edelarua commented Jul 3, 2024

Pull Request

General updates to the cardinal website after rename:

  • Add required versions to DESCRIPTION file
  • Update installation instructions for random.cdisc.data which is now on CRAN
  • Change "rtables/tern" in section titles to just "rtables"
  • Update site colours to shades of red instead of green (could be modified)
  • Temporarily revert logo to pharmaverse logo instead of falcon logo
  • Up test coverage

@edelarua edelarua added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 3, 2024
@edelarua edelarua requested a review from ayogasekaram July 3, 2024 18:15
Copy link
Contributor

github-actions bot commented Jul 3, 2024

badge

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------
R/fda-fig_01.R         75       0  100.00%
R/fda-fig_02.R         75       0  100.00%
R/fda-fig_14.R        115       0  100.00%
R/fda-table_02.R      166       0  100.00%
R/fda-table_03.R       35       0  100.00%
R/fda-table_04.R       63       0  100.00%
R/fda-table_05.R       61       0  100.00%
R/fda-table_06.R       76       0  100.00%
R/fda-table_07.R       35       0  100.00%
R/fda-table_08.R       46       0  100.00%
R/fda-table_09.R      329       0  100.00%
R/fda-table_10.R       26       0  100.00%
R/fda-table_11.R       42       0  100.00%
R/fda-table_12.R       40       0  100.00%
R/fda-table_13.R       20       0  100.00%
R/fda-table_14.R       27       0  100.00%
R/fda-table_15.R       32       0  100.00%
R/fda-table_16.R       32       0  100.00%
R/fda-table_17.R       32       0  100.00%
R/fda-table_18.R       32       0  100.00%
R/fda-table_20.R       71       0  100.00%
R/fda-table_21.R       78       0  100.00%
R/fda-table_22.R       77       0  100.00%
R/fda-table_32.R       94       0  100.00%
R/fda-table_33.R       95       0  100.00%
R/fda-table_34.R       41       0  100.00%
R/fda-table_35.R       23       0  100.00%
R/fda-table_36.R       30       0  100.00%
R/fda-table_38.R       39       0  100.00%
R/utils.R              28       0  100.00%
TOTAL                1935       0  100.00%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  -------
R/fda-table_09.R       -4      -4  +1.20%
R/fda-table_35.R        0      -1  +4.35%
R/fda-table_36.R        0      -1  +3.33%
TOTAL                  -4      -6  +0.31%

Results for commit: 1088b34

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Unit Tests Summary

  1 files   29 suites   1m 9s ⏱️
130 tests 130 ✅   0 💤 0 ❌
472 runs  350 ✅ 122 💤 0 ❌

Results for commit 1088b34.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
fda-table_35 👶 $+0.18$ Table_35_generation_works_with_pruning
fda-table_36 👶 $+0.47$ Table_36_generation_works_with_pruning

Results for commit ff06a8b

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@ayogasekaram ayogasekaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me! Thank you so much @edelarua

@edelarua edelarua merged commit 0d2645d into main Jul 4, 2024
24 checks passed
@edelarua edelarua deleted the update_site@main branch July 4, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants