Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing table 36 screenshot #236

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Add missing table 36 screenshot #236

merged 4 commits into from
Aug 19, 2024

Conversation

edelarua
Copy link
Collaborator

Pull Request

Closes #233

Copy link
Contributor

github-actions bot commented Jul 25, 2024

badge

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------
R/fda-fig_01.R         75       0  100.00%
R/fda-fig_02.R         75       0  100.00%
R/fda-fig_14.R        115       0  100.00%
R/fda-table_02.R      166       0  100.00%
R/fda-table_03.R       35       0  100.00%
R/fda-table_04.R       63       0  100.00%
R/fda-table_05.R       61       0  100.00%
R/fda-table_06.R       76       0  100.00%
R/fda-table_07.R       35       0  100.00%
R/fda-table_08.R       46       0  100.00%
R/fda-table_09.R      329       0  100.00%
R/fda-table_10.R       26       0  100.00%
R/fda-table_11.R       42       0  100.00%
R/fda-table_12.R       40       0  100.00%
R/fda-table_13.R       20       0  100.00%
R/fda-table_14.R       27       0  100.00%
R/fda-table_15.R       32       0  100.00%
R/fda-table_16.R       32       0  100.00%
R/fda-table_17.R       32       0  100.00%
R/fda-table_18.R       32       0  100.00%
R/fda-table_20.R       71       0  100.00%
R/fda-table_21.R       78       0  100.00%
R/fda-table_22.R       77       0  100.00%
R/fda-table_32.R       94       0  100.00%
R/fda-table_33.R       95       0  100.00%
R/fda-table_34.R       41       0  100.00%
R/fda-table_35.R       23       0  100.00%
R/fda-table_36.R       30       0  100.00%
R/fda-table_38.R       39       0  100.00%
R/utils.R              28       0  100.00%
TOTAL                1935       0  100.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ff2de83

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Unit Tests Summary

  1 files   29 suites   1m 12s ⏱️
130 tests 130 ✅   0 💤 0 ❌
472 runs  350 ✅ 122 💤 0 ❌

Results for commit ff2de83.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
fda-table_09 💔 $8.13$ $+1.10$ $0$ $0$ $0$ $0$

Results for commit 01bc983

♻️ This comment has been updated with latest results.

@jknizia jknizia self-requested a review August 14, 2024 06:12
Copy link
Collaborator

@jknizia jknizia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Emily, thanks for adding the screenshot! I have rendered the page locally and found that the "Function Details" tab of the page is not displayed correctly:

image

image

Could you please check on your end whether it is the same for you?

@edelarua
Copy link
Collaborator Author

Hi Emily, thanks for adding the screenshot! I have rendered the page locally and found that the "Function Details" tab of the page is not displayed correctly:

Hi @jknizia,

Thanks for the review! I went through all of the templates and fixed the tables (ef5ffa1) so this shouldn't occur anywhere on the site now :)

@jknizia
Copy link
Collaborator

jknizia commented Aug 15, 2024

Hi Emily, thanks for adding the screenshot! I have rendered the page locally and found that the "Function Details" tab of the page is not displayed correctly:

Hi @jknizia,

Thanks for the review! I went through all of the templates and fixed the tables (ef5ffa1) so this shouldn't occur anywhere on the site now :)

Great, thank you!

@edelarua edelarua merged commit 817f87a into main Aug 19, 2024
24 checks passed
@edelarua edelarua deleted the 233_table_36_image@main branch August 19, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Spec. Screenshot for FDA Table 36 not visible
2 participants