-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table 6 w/ gtsummary #249
base: main
Are you sure you want to change the base?
Conversation
Unit Test Performance Difference
Additional test case details
Results for commit 5c7527e ♻️ This comment has been updated with latest results. |
Merge branch '237-new-ard-ard-for-table-06' of https://github.com/pharmaverse/falcon into 237-new-ard-ard-for-table-06 # Conflicts: # R/fda-table_06.R # tests/testthat/test-fda-table_06.R
::: panel-tabset | ||
## Spec. Screenshot | ||
|
||
{fig-align="center"} | ||
|
||
## gtsummary Table | ||
|
||
## rtables Table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed, since rtables comes a little bit later
### `make_table_06()` | ||
<details> | ||
<summary>Function Details</summary> | ||
### `make_table_11_rtables()` | ||
|
||
------------------------------------------------------------------------ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 153 there is a missing </details>
Dear @mattkorb, thank you so much for the review. I have addressed your comments. |
Unit Tests Summary 1 files 30 suites 1m 41s ⏱️ For more details on these errors, see this check. Results for commit 1e73949. |
Hi @ayogasekaram, it seems like the PR checks fail due to a test fail that is not related to my work: Is this the same test that fails on your branch? |
Pull Request
Closes #237