Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table 6 w/ gtsummary #249

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

jknizia
Copy link
Collaborator

@jknizia jknizia commented Mar 6, 2025

Pull Request

Closes #237

@jknizia jknizia linked an issue Mar 6, 2025 that may be closed by this pull request
7 tasks
@jknizia jknizia requested a review from mattkorb March 6, 2025 14:39
@jknizia jknizia marked this pull request as ready for review March 6, 2025 14:52
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
fda-table_06 💔 $1.62$ $+17.78$ $+90$ $+3$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
fda-table_06 👶 $+5.75$ Table_06_generation_works_with_custom_labels
fda-table_06 💀 $0.59$ $-0.59$ Table_06_generation_works_with_custom_values
fda-table_06 💔 $0.47$ $+5.89$ Table_06_generation_works_with_default_values
fda-table_06 💀 $0.56$ $-0.56$ Table_06_generation_works_with_risk_difference_column
fda-table_06 👶 $+5.72$ Table_06_returns_ARD_if_specified
fda-table_06 👶 $+0.59$ Table_06_rtables_generation_works_with_custom_values
fda-table_06 👶 $+0.43$ Table_06_rtables_generation_works_with_default_values
fda-table_06 👶 $+0.54$ Table_06_rtables_generation_works_with_risk_difference_column

Results for commit 5c7527e

♻️ This comment has been updated with latest results.

jknizia and others added 4 commits March 6, 2025 16:46
Merge branch '237-new-ard-ard-for-table-06' of https://github.com/pharmaverse/falcon into 237-new-ard-ard-for-table-06

# Conflicts:
#	R/fda-table_06.R
#	tests/testthat/test-fda-table_06.R
::: panel-tabset
## Spec. Screenshot

![](../assets/images/screenshots/table_06.png){fig-align="center"}

## gtsummary Table

## rtables Table
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed, since rtables comes a little bit later

### `make_table_06()`
<details>
<summary>Function Details</summary>
### `make_table_11_rtables()`

------------------------------------------------------------------------

Copy link
Collaborator

@mattkorb mattkorb Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 153 there is a missing </details>

@jknizia
Copy link
Collaborator Author

jknizia commented Mar 12, 2025

Dear @mattkorb, thank you so much for the review. I have addressed your comments.

Copy link
Contributor

Unit Tests Summary

  1 files   30 suites   1m 41s ⏱️
140 tests 139 ✅   0 💤 0 ❌ 1 🔥
586 runs  453 ✅ 132 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit 1e73949.

@jknizia
Copy link
Collaborator Author

jknizia commented Mar 12, 2025

Hi @ayogasekaram, it seems like the PR checks fail due to a test fail that is not related to my work:

image

Is this the same test that fails on your branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New ARD]: ARD for table 06
2 participants