supp domain generation #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ShiyuC
commented
Mar 12, 2025
| #' | ||
| #' @param sdtm_dataset SDTM output used to split supplemental domains. | ||
| #' @param idvar Variable name used to for variable. | ||
| #' @param spec Data frame of specifications.. |
There was a problem hiding this comment.
Try to incorporate xportr_spec; Let the user define the input of label and origin
| #' @param spec Data frame of specifications.. | ||
| #' @param eval Character string of the evaluator. | ||
| #' | ||
| #' @return Supplemental domains. |
There was a problem hiding this comment.
Return a list of data frames - 1. sdtm with suppquals dropped; 2. supp-- domain
| function(sdtm_dataset = NULL, | ||
| idvar = NULL, | ||
| spec = NULL, | ||
| eval = NA_character_ ### Should this be 1 single character value or a vector? |
There was a problem hiding this comment.
Check with SMEs - if it's not a single value across the entire supp- domain, then users need to manually program it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #111
Request Title (Use Edit button in top-right if you need to update)
tidyverse style guide. Run
styler::style_file()to style R and Rmd filesconsider realistic data scenarios and edge cases, e.g. empty datasets, errors,
boundary cases etc. - See
Unit Test Guide
fully follow the
deprecation guidance?
and families. Refer to the
categorization of functions to tag appropriate keyword/family.
devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdif the changes pertain to a user-facing function (i.e. ithas an
@exporttag) or documentation aimed at users (rather than developers)pkgdown::build_site()and check that all affectedexamples are displayed correctly and that all new functions occur on the "Reference" page.
lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()