-
-
Notifications
You must be signed in to change notification settings - Fork 181
Live Preview Image #2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Preview Image #2401
Conversation
578c035 to
9a66f5d
Compare
…on as tag markers are updated
…es from overriding it
…der right is obscuring it
|
| let rect = element.getBoundingClientRect(); | ||
| marker.style.position = "fixed"; | ||
| marker.style.zIndex = "2147483646"; | ||
| marker.style.zIndex = "2147483647"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the highest z-index number allowed. This is done so that no user written styles can override our elements
| .catch(error => { | ||
| console.error('Failed to fetch images:', error); | ||
| if (!append) { | ||
| this._showError('Failed to load images'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localise error messages




No description provided.