Skip to content

Conversation

@devvaannsh
Copy link
Member

No description provided.

@devvaannsh devvaannsh force-pushed the img branch 7 times, most recently from 578c035 to 9a66f5d Compare September 23, 2025 04:53
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

let rect = element.getBoundingClientRect();
marker.style.position = "fixed";
marker.style.zIndex = "2147483646";
marker.style.zIndex = "2147483647";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this number

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the highest z-index number allowed. This is done so that no user written styles can override our elements

.catch(error => {
console.error('Failed to fetch images:', error);
if (!append) {
this._showError('Failed to load images');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localise error messages

@abose abose merged commit 354485e into main Sep 25, 2025
12 of 19 checks passed
@abose abose deleted the img branch September 25, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants